[PATCH] D16311: [AVR] Add AVRTargetStreamers

[Matt Arsenault via llvm-commits]

arsenm added a comment.

I'm not particularly familiar with MC bits, but besides these minor cleanups this looks OK to me


================
Comment at: lib/Target/AVR/MCTargetDesc/AVRTargetStreamer.cpp:21-22
@@ +20,4 @@
+
+namespace {
+  unsigned GetEFlagsForFeatureSet(const FeatureBitset &Features) {
+    unsigned EFlags = 0;
----------------
Convention is for new functions to start with a lowercase letter, and to use static functions instead of an anonymous namespace.

================
Comment at: lib/Target/AVR/MCTargetDesc/AVRTargetStreamer.cpp:74-76
@@ +73,5 @@
+
+AVRTargetELFStreamer::AVRTargetELFStreamer(MCStreamer &S,
+                                           const MCSubtargetInfo &STI)
+    : AVRTargetStreamer(S) {
+
----------------
Convention is also that the ELF / other specific object format Streamer be kept in a separate file


http://reviews.llvm.org/D16311