[PATCH] D17128: [SimplifyCFG] Don't fold conditional branches that contain calls to convergent functions.

[Jingyue Wu via llvm-commits]

jingyue added inline comments.

================
Comment at: test/Transforms/SimplifyCFG/attr-convergent.ll:21
@@ +20,3 @@
+  call void @barrier()
+  br i1 %cmp, label %cond.end, label %cond.false
+
----------------
This test doesn't directly reflect your change because `%cmp` is not a PHINode. In fact, SimplifyCFG optimizes `%cmp` to PHINode before it worries about whether `@barrier` is convergent. 

It would be more straight-forward to write a test where the containing block of `@barrier` directly branches at a PHINode directly. 


http://reviews.llvm.org/D17128