[PATCH] D16892: [lld] [ELF/AArch64] Add support to some GD/LE/IS TLS relocation

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits.


================
Comment at: ELF/Target.cpp:1434
@@ +1433,3 @@
+    uint64_t V = llvm::alignTo(TcbSize, Out<ELF64LE>::TlsPhdr->p_align) + SA;
+    updateAArch64Add(Loc, (V & 0xFFF));
+    break;
----------------
(V & 0xFFF) -> V & 0xFFF

================
Comment at: ELF/Target.cpp:1470
@@ +1469,3 @@
+    if (canBePreempted(S, true)) {
+      llvm_unreachable("Unsupported TLS optimization");
+    } else {
----------------
llvm_unreachable -> fatal

================
Comment at: ELF/Target.cpp:1471
@@ +1470,3 @@
+      llvm_unreachable("Unsupported TLS optimization");
+    } else {
+      uint64_t X = S ? S->getVA<ELF64LE>() : SA;
----------------
Since fatal is a noreturn function, you don't need this else clause.

  if (canBePreempted(S, true))
    fatal(...)
  uint64_t X = ...


http://reviews.llvm.org/D16892