[PATCH] D16940: Fix build LLVM with -D LLVM_USE_INTEL_JITEVENTS:BOOL=ON on Windows

[Andy Kaylor via llvm-commits]

andrew.w.kaylor added inline comments.

================
Comment at: lib/ExecutionEngine/IntelJITEvents/CMakeLists.txt:17
@@ +16,2 @@
+
+add_dependencies(LLVMIntelJITEvents LLVMCodeGen)
----------------
beanz wrote:
> andrew.w.kaylor wrote:
> > I'm not 100% sure that the change I made matches what you are suggesting, but it appears to fix the problem in the 3.8 branch.
> Just a nitpick. When linking LLVM components instead of calling add_dependencies you can set LLVM_LINK_COMPONENTS before calling add_llvm_library.
> 
> Adding something like this to the top of the file is the more normal way to handle this:
> 
> 
> ```
> set(LLVM_LINK_COMPONENTS Support)
> ```
That doesn't appear to fix the build problem.

I tried

set(LLLVM_LINK_COMPONENTS CodeGen)

and

set(LLVM_LINK_COMPONENTS Support CodeGen)

Could this be an issue because I am declaring a library and not a tool?

All the similar files I've looked at seem to be using some form of adding a dependency directly on intrinsics_gen.  Many of them seem to have come from r239796 (http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150615/281739.html).


Repository:
  rL LLVM

http://reviews.llvm.org/D16940