[PATCH] D16809: [JumpThreading] See through Cast Instructions

[Geoff Berry via llvm-commits]

gberry added inline comments.

================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:414
@@ +413,3 @@
+  Instruction *I = dyn_cast<Instruction>(V);
+  if (I && !isa<PHINode>(I))
+    if (auto *NewV = SimplifyInstruction(I, BB->getModule()->getDataLayout())) {
----------------
It seems like this block deserves a single-line comment explaining why it is being done.

================
Comment at: test/Transforms/JumpThreading/basic.ll:514
@@ +513,3 @@
+
+;;; Just check that it doesn't crash / assert
+define i32 @test17() {
----------------
Can you give some indication of what kind of crash/assert you are testing for here?


Repository:
  rL LLVM

http://reviews.llvm.org/D16809