[compiler-rt] r260481 - Un-XFAIL a passing test on Windows

[Reid Kleckner via llvm-commits]

This looks like a static/dynamic C runtime mismatch. I configured my
checkout locally to use the static runtime, and the buildbot is using the
default of dynamic. On the buildbot, the profile library is getting linked
against msvcrt and the test code is linked against libcmt. Linking these
objects together will fail.

If we really want the coverage library to work on Windows, we either need
to avoid use of the CRT or provide two versions, one dynamic one static.
Last of all we could make the profiling library into a DLL.

Anyway, we don't currently run test/profile on Windows at all, so let's
disable this test completely for now.

On Thu, Feb 11, 2016 at 10:16 AM, Alexey Samsonov <vonosmas at gmail.com>
wrote:

> Actually, it's still failing on the bot:
> http://lab.llvm.org:8011/builders/sanitizer-windows/builds/16985/steps/run%20tests/logs/stdio
>
> On Wed, Feb 10, 2016 at 6:02 PM, Reid Kleckner via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> Author: rnk
>> Date: Wed Feb 10 20:02:56 2016
>> New Revision: 260481
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=260481&view=rev
>> Log:
>> Un-XFAIL a passing test on Windows
>>
>> Modified:
>>     compiler-rt/trunk/test/asan/TestCases/asan_and_llvm_coverage_test.cc
>>
>> Modified:
>> compiler-rt/trunk/test/asan/TestCases/asan_and_llvm_coverage_test.cc
>> URL:
>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/TestCases/asan_and_llvm_coverage_test.cc?rev=260481&r1=260480&r2=260481&view=diff
>>
>> ==============================================================================
>> --- compiler-rt/trunk/test/asan/TestCases/asan_and_llvm_coverage_test.cc
>> (original)
>> +++ compiler-rt/trunk/test/asan/TestCases/asan_and_llvm_coverage_test.cc
>> Wed Feb 10 20:02:56 2016
>> @@ -1,6 +1,6 @@
>>  // RUN: %clangxx_asan -coverage -O0 %s -o %t
>>  // RUN: %env_asan_opts=check_initialization_order=1 %run %t 2>&1 |
>> FileCheck %s
>> -// XFAIL: android,win32
>> +// XFAIL: android
>>  #include <stdio.h>
>>  int foo() { return 1; }
>>  int XXX = foo();
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>
>
>
> --
> Alexey Samsonov
> vonosmas at gmail.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160211/5628efe3/attachment.html>