[PATCH] D16908: Add a test case to show isKnownNonZero() returns correctly; NFC

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 11 09:04:26 PST 2016


mcrosier accepted this revision.
mcrosier added a comment.

LGTM, with minor nits.


================
Comment at: test/Transforms/InstSimplify/compare.ll:336
@@ -335,1 +335,3 @@
 
+; Do not expect to simplify if we cannot guarantee that
+; the ConstantExpr is a non-zero constant.
----------------
Please drop "expect to".

Also, please maximize 80-column.


http://reviews.llvm.org/D16908





More information about the llvm-commits mailing list