[PATCH] D17138: AVX512: Change store size of kmask.

Elena Demikhovsky via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 11 06:41:12 PST 2016


delena added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:11979
@@ -11978,5 +11978,3 @@
   unsigned IdxVal = cast<ConstantSDNode>(Idx)->getZExtValue();
-  const TargetRegisterClass* rc = getRegClassFor(VecVT);
-  if (!Subtarget.hasDQI() && (VecVT.getVectorNumElements() <= 8))
-    rc = getRegClassFor(MVT::v16i1);
-  unsigned MaxSift = rc->getSize()*8 - 1;
+  if (!Subtarget.hasDQI() && (VecVT.getVectorNumElements() <= 8)) {
+    // Use kshiftlw/rw instruction.
----------------
You, probably, need a test that covers these new lines.

================
Comment at: lib/Target/X86/X86InstrInfo.cpp:4310
@@ -4305,3 +4309,3 @@
 static bool MaskRegClassContains(unsigned Reg) {
   return X86::VK8RegClass.contains(Reg) ||
          X86::VK16RegClass.contains(Reg) ||
----------------
Here should also be one line. And one line comment for each.


Repository:
  rL LLVM

http://reviews.llvm.org/D17138





More information about the llvm-commits mailing list