[PATCH] D16871: lit: Allow arbitrary key/value data in a test result

[Matthias Braun via llvm-commits]

MatzeB added a comment.

In http://reviews.llvm.org/D16871#349237, @ddunbar wrote:

> I would just use addMetric for this. I see a binary signature as just
>  another kind of metric data, sometimes people even use the term "measure"
>  to the process of computing a hash signature for a binary.


I'm sure mathematicians will cry seeing the terms used like this, or they get nerd sniped into defining a metric space on md5sums :)

Anyway my thinking was mainly that analysis software can know which things we can compute deltas between runs and plot graphs and which information does not fit this category. Then again we can just check whether the datatype is a number or not, so I'll go with addMetric() then if an addData() is deemed unnecessary.

PS: For the record: lnt already collects md5sums, I just think that it would be more natural to collect such data with the test-suite lit runner (also because I like to run custom analysis scripts on the test-suite/lit output).


Repository:
  rL LLVM

http://reviews.llvm.org/D16871