[PATCH] D17082: FunctionImport: add a progressive heuristic to limit importing too deep in the callgraph

[Mehdi AMINI via llvm-commits]

joker.eph added inline comments.

================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:305
@@ +304,3 @@
+  // First step is collecting the called external functions.
+  // We keep the function name as long as the import threshold for its callees.
+  VisitedFunctionTrackerTy VisitedFunctions;
----------------
tejohnson wrote:
> "as long as" doesn't sound right. Did you mean "as well as"?
Yes!

================
Comment at: test/Transforms/FunctionImport/Inputs/adjustable_threshold.ll:20
@@ +19,3 @@
+
+; Size is 5: if two layers below in the call graph the threshold will be 4,
+; but if only one layer below the threshold will be 7.
----------------
tejohnson wrote:
> Size must start out higher than 5 since it looks like the evolution factor had to be reduced to 0.5 to not get this imported. 
Not sure I understand what you mean?  I want it to be imported with the default 0.7 factor, but not with the 0.5 one.


http://reviews.llvm.org/D17082