[PATCH] D9067: LiveIntervalAnalysis: Support moving of subregister defs in handleMove

[Quentin Colombet via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi Matthias,

LGTM.
Few nitpicks inlined.

Cheers,
-Quentin


================
Comment at: lib/CodeGen/LiveIntervalAnalysis.cpp:1052
@@ +1051,3 @@
+          SlotIndex::isEarlierInstr(Next->start, NewIdx)) {
+        // If we are here then we OldIdx was just a use but not a def. We only
+        // have to ensure liveness extends to NewIdx.
----------------
s/we//

================
Comment at: lib/CodeGen/LiveIntervalAnalysis.cpp:1112
@@ +1111,3 @@
+        // There is no gap between OldIdxOut and its predecessor anymore,
+        // merge them
+        LiveRange::iterator IPrev = std::prev(OldIdxOut);
----------------
Period.

================
Comment at: lib/CodeGen/LiveIntervalAnalysis.cpp:1263
@@ +1262,3 @@
+            SlotIndex::isEarlierInstr(NewIdxDef, OldIdxIn->start)) {
+          // OldIdx is not a dead def and NewIdx is before predecessor start
+          LiveRange::iterator NewIdxIn = NewIdxOut;
----------------
Period.


Repository:
  rL LLVM

http://reviews.llvm.org/D9067