[PATCH] D14596: [SROA] Choose more profitable type in findCommonType

Guozhi Wei via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 14:16:09 PST 2016


Carrot marked 13 inline comments as done.
Carrot added a comment.

In http://reviews.llvm.org/D14596#347537, @majnemer wrote:

> I think this can be N**2 if there is a big tree of phi nodes with bitcasts at different levels of the tree.  It might make sense to limit the total amount of work we are willing to do this combine.
>
> How many items of work does the worklist typically process before firing?


In the regression testing there are 1.01 PHI nodes added to the worklist in average, the maximum is 3.


http://reviews.llvm.org/D14596





More information about the llvm-commits mailing list