[PATCH] D17086: [NVPTX] emit .file directives for files referenced by subprograms.

[David Blaikie via llvm-commits]

dblaikie accepted this revision.
dblaikie added a reviewer: dblaikie.
dblaikie added a comment.

Looks good - but please simplify the test a bit further and include the basic C code that produced the IR (I realize the IR is fairly simple, but it's handy to have what the code is modelling, the metadata format we have currently is still fairly verbose/hard to read)

The test could be simplier if it were C rather than C++ (no name mangling) and just void functions taking no parameters, I would imagine.

  void foo() {
  }
  #line 1 other.c
  void bar() {
  }

Something like that, I would imagine.

Separately, this code seems strange - why does NVPTXAsmPrinter::recordAndEmitFilenames exist? It seems insufficient (what about file names on types? (DW_AT_decl_file on a user-defined type) why doesn't code like this exist for any other target? etc)


http://reviews.llvm.org/D17086