[PATCH] D17048: [WebAssembly] Switch varags calling convention to use a register

[Dan Gohman via llvm-commits]

sunfish added a comment.

Looks good!


================
Comment at: lib/Target/WebAssembly/WebAssemblyFrameLowering.cpp:51
@@ -50,3 +51,1 @@
-         MFI->hasStackMap() || MFI->hasPatchPoint() ||
-         RegInfo->needsStackRealignment(MF);
 }
----------------
I think we should support __builtin_frame_address(0), but if you want to remove the MFI->isFrameAddressTaken() check for now, it'd be good to add an assert right here, in this function, so that if we ever set it we can be quickly pointed to the place where it needs to be handled.

================
Comment at: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:364
@@ +363,3 @@
+    // to the stack buffer at the offsets computed above.
+    int FI = MF.getFrameInfo()->CreateStackObject(NumBytes, /*Alignment=*/16,
+                                                  /*isSS=*/false);
----------------
Instead of hard-coding a 16 here, let's use the DataLayout's getStackAlignment().


Repository:
  rL LLVM

http://reviews.llvm.org/D17048