[PATCH] D17042: AMDGPU/SI: move SMRD to flat if UseFlatForGlobal is true

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: test/CodeGen/AMDGPU/salu-to-valu.ll:55-60
@@ -54,7 +54,7 @@
 
 ; GCN-LABEL: {{^}}smrd_valu:
-; FIXME: We should be using flat load for HSA.
-; GCN: buffer_load_dword [[OUT:v[0-9]+]]
+; GCN-NOHSA: buffer_load_dword [[OUT:v[0-9]+]]
+; GCN-HSA: flat_load_dword [[OUT:v[0-9]+]]
 ; GCN-NOHSA: buffer_store_dword [[OUT]]
 ; GCN-HSA: flat_store_dword [[OUT]]
 define void @smrd_valu(i32 addrspace(2)* addrspace(1)* %in, i32 %a, i32 %b, i32 addrspace(1)* %out) #1 {
----------------
tstellarAMD wrote:
> I think you should add more test cases testing the edge cases for the immediate offsets.
This test should also have a VI run line added


http://reviews.llvm.org/D17042