[lld] r260224 - Use the plt entry as the address of some symbols.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 07:40:51 PST 2016


>> -    return S.isShared();
>> +    if (!S.isShared())
>> +      return false;
>> +    S.NeedsCopyOrPltAddr = true;
>
>
> Can you move this to a caller of needsPlt (probably to scanRelocs)? needsPlt
> is, by its name implies, a predicate, so it is not expected to mutate a
> given object.

Yes, but it is a bit verbose. I uploaded the patch to
http://reviews.llvm.org/D17073.

Cheers,
Rafael


More information about the llvm-commits mailing list