[PATCH] D16991: Split the creation of program headers in a few steps

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 07:16:37 PST 2016


>
> ================
> Comment at: ELF/Writer.cpp:1324
> @@ +1323,3 @@
> +
> +    if (needsPhdr<ELFT>(Sec)) {
> +      // Don't allocate VA space for TLS NOBITS sections. The PT_TLS PHDR is
> ----------------
> Why process only needsPhdr sections?

Other sections don't have a VA, which is what we set in the if body.


I will upload a patch with the other suggestions.

Cheers,
Rafael


More information about the llvm-commits mailing list