[PATCH] D16986: [LICM] Don't assert on volatile accesses

Ed Baunton via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 10 03:36:17 PST 2016


edbaunton added a comment.

Another option would be to adjust the AliasSetTracker's `add` method to check if any of the `users` of the instruction are volatile and then mark the set as as volatile (currently it only checks if the instruction itself is volatile before marking the set as volatile). This would be a bit more inefficient as you would have to loop for every user of every load and store added to the set but it would mean no change to the LICM logic... I am not sure which is more correct.


http://reviews.llvm.org/D16986





More information about the llvm-commits mailing list