[PATCH] D17065: Defer CWD in MCContext lookup as late as possible.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 23:18:55 PST 2016


chandlerc added a comment.

The goal here makes perfect sense, but I wonder if this is the right fix... It seems almost too surgical, and makes it really easy to change MC in a way that yet again violates things.

I feel like the MCContext shouldn't be looking at the filesystem *at all*, and it should be the client that sets up the MCContext that provides a compilation directory, potentially via the filesystem query, where appropriate. Does that make sense here?


Repository:
  rL LLVM

http://reviews.llvm.org/D17065





More information about the llvm-commits mailing list