[PATCH] D15393: [X86] Order the local stack symbols to improve code size and locality.

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 23:03:34 PST 2016


majnemer added inline comments.

================
Comment at: lib/Target/X86/X86FrameLowering.cpp:2697
@@ +2696,3 @@
+    // The density is calculated by doing :
+    //     (double)DensityA = A.ObjectNumUses / A.ObjectSize
+    //     (double)DensityB = B.ObjectNumUses / B.ObjectSize
----------------
silvas wrote:
> Tiny nit: This comment reference "double" but the code doesn't seem to be using floating point anymore.
This comment addresses this later on with: "This ends up factoring the division and, with it, the need for any floating arithmetic."


http://reviews.llvm.org/D15393





More information about the llvm-commits mailing list