[PATCH] D15393: [X86] Order the local stack symbols to improve code size and locality.

[Zia Ansari via llvm-commits]

zansari marked 6 inline comments as done.

================
Comment at: lib/Target/X86/X86FrameLowering.cpp:2756-2757
@@ +2755,4 @@
+    if (ObjectSize == 0)
+      // Variable size. Just use 4.
+      SortingObjects[Obj].ObjectSize = 4;
+    else      
----------------
majnemer wrote:
> Why?  Why not 1?
I couldn't think of any number that made sense, so I just arbitrarily picked 4. I figured that 1 would probably make less sense, since most allocas, for example, would probably be > 1B. If you feel 1 would make more sense, I wouldn't have any issues changing it. I doubt it would make much difference in the grand scheme of things.


http://reviews.llvm.org/D15393