[PATCH] D16751: Enable constexpr on Visual Studio 2015, add support for two equivalent attributes

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 18:30:32 PST 2016


joker.eph added a subscriber: joker.eph.
joker.eph added a comment.

In http://reviews.llvm.org/D16751#347196, @aaron.ballman wrote:

> In http://reviews.llvm.org/D16751#347027, @ariccio wrote:
>
> > Pardon my ignorance, but what //exactly// does `This revision is now accepted and ready to land.` mean? I assume it's waiting on something?
> >
> > No, I don't mean literally <https://github.com/phacility/phabricator/blob/master/src/applications/differential/storage/DifferentialTransaction.php#L284>.
>
>
> It means that the revision is no longer in review status and you are welcome to commit the patch to trunk. The next step is for you (or someone else) to commit these changes, and then you should watch for build bot failures (in IRC is preferred, though you will get an email from most bots if your patch is in a batch of commits that causes a failure), and watch for any post-commit review feedback (which generally comes in on either this thread, or the thread started by the automated commit email).


To be more explicit: if you don't have commit access, usually you need to ask here for someone to commit it for you.
To get commit access, see: http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access


http://reviews.llvm.org/D16751





More information about the llvm-commits mailing list