[PATCH] D15390: [ThinLTO] Launch importing backends in parallel threads from gold plugin

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 16:54:54 PST 2016


rafael added inline comments.

================
Comment at: tools/gold/gold-plugin.cpp:972
@@ +971,3 @@
+
+  // We create a new CodeGen object for each thread, since each needs a
+  // separate output stream and TargetMachine.
----------------
s/thread/task/

================
Comment at: tools/gold/gold-plugin.cpp:1029
@@ +1028,3 @@
+  {
+    ThreadPool CodegenThreadPool(MaxThreads);
+    for (auto &BC : BCs) {
----------------
It is nice that now we always use a ThreadPool.

It would be awesome if this could be refactored so that there was just one ThreadPool for thinlto and conventional parallel codegen.




http://reviews.llvm.org/D15390





More information about the llvm-commits mailing list