[PATCH] D17048: [WebAssembly] Switch varags calling convention to use a register

[Derek Schuff via llvm-commits]

dschuff added a comment.

A couple of questions:


================
Comment at: lib/Target/WebAssembly/InstPrinter/WebAssemblyInstPrinter.cpp:149
@@ -148,3 +148,1 @@
   } else if (Op.isImm()) {
-    assert((OpNo < MII.get(MI->getOpcode()).getNumOperands() ||
-            (MII.get(MI->getOpcode()).TSFlags &
----------------
I don't really understand what this assert is for. Is it OK to remove it? Should I put in something else?

================
Comment at: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:621
@@ +620,3 @@
+
+  // XXX if ARGUMENTS is not live-in to the block already this doesn't make it
+  // live in.
----------------
One issue I currently have is that if ARGUMENTS is not live-in to the current block, then I get  machineinstr verifier error because adding this reference does not add ARGUMENTS to the live-ins for the block. I could add it manually here, but I don't see a good way to get the current MBB from the current SelectionDAG, so maybe that's not the right thing to do. Any ideas?


http://reviews.llvm.org/D17048