[PATCH] D16937: Add icmp and conditional branches in the C API echo test.
Amaury SECHET via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 9 14:44:43 PST 2016
deadalnix added inline comments.
================
Comment at: tools/llvm-c-test/echo.cpp:230
@@ +229,3 @@
+ LLVMValueRef Then = LLVMGetOperand(Src, 2);
+ LLVMBasicBlockRef ThenBB = DeclareBB(LLVMValueAsBasicBlock(Then));
+ Dst = LLVMBuildCondBr(Builder, Cond, ThenBB, ElseBB);
----------------
joker.eph wrote:
> It seems to me that "Then" and "Else" are reversed?
I was surprized by this to when making that diff, but it looks like it is this way.
http://reviews.llvm.org/D16937
More information about the llvm-commits
mailing list