[PATCH] D16935: [PGO] Indirect-call profile annotation in IR level

David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 14:41:45 PST 2016


davidxl added inline comments.

================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:734
@@ +733,3 @@
+  unsigned NumTargets =
+      ProfileRecord.getNumValueSites(IPVK_IndirectCallTarget);
+  if (NumTargets == 0)
----------------
Better check ICV's number of icall instructions matches the number of NumValueSites. If not give warning and return.


http://reviews.llvm.org/D16935





More information about the llvm-commits mailing list