[PATCH] D14128: Enable readobj to emit readelf like output.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 14:00:15 PST 2016


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

Couple inline comments. LGTM.


================
Comment at: tools/llvm-readobj/StreamWriter.cpp:5
@@ -4,2 +4,3 @@
 #include <cctype>
+#include <sstream>
 
----------------
Needed?

================
Comment at: tools/llvm-readobj/llvm-readobj.h:45
@@ -44,1 +44,3 @@
   extern llvm::cl::opt<bool> MipsPLTGOT;
+  enum OutpytStyleTy { LLVM, GNU };
+  extern llvm::cl::opt<OutpytStyleTy> OutputStyle;
----------------
"Output"


Repository:
  rL LLVM

http://reviews.llvm.org/D14128





More information about the llvm-commits mailing list