[PATCH] D17037: [MemoryBuiltins] Fix an issue with hasNoAliasAttr

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 13:58:19 PST 2016


sanjoy added inline comments.

================
Comment at: lib/Analysis/MemoryBuiltins.cpp:147
@@ -146,3 +146,3 @@
   ImmutableCallSite CS(LookThroughBitCast ? V->stripPointerCasts() : V);
-  return CS && CS.hasFnAttr(Attribute::NoAlias);
 }
----------------
reames wrote:
> Can you add an assert inside the attribute mechanism that would have caught this?
That's a good idea, I'll do that in a follow-up patch.


http://reviews.llvm.org/D17037





More information about the llvm-commits mailing list