[PATCH] D14128: Enable readobj to emit readelf like output.

khemant@codeaurora.org via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 12:52:44 PST 2016


khemant added inline comments.

================
Comment at: tools/llvm-readobj/llvm-readobj.h:45
@@ -44,2 +44,3 @@
   extern llvm::cl::opt<bool> MipsPLTGOT;
+  extern llvm::cl::opt<bool> GNUStyle;
 } // namespace opts
----------------
echristo wrote:
> Hate to ask at the last minute but can you make this an enum (admittedly with two choices) so that the checks in the code are positive? (e.g. OutputStyle == GNU and OutputStyle == LLVM)
Sure.


Repository:
  rL LLVM

http://reviews.llvm.org/D14128





More information about the llvm-commits mailing list