[PATCH] D16203: [AArch64] Remove copy zero after cbz/cbnz

Jun Bum Lim via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 9 07:50:15 PST 2016


junbuml added a comment.

Thanks Matthias for the review.

> the algorithm is not using any other information or methods of that pass (except for the fact that the pass iterates over all basic blocks). This is not enough reason to introduce a new TII callback. You can just as well make this a standalone aarch64 specific pass.


I also agree with your comments , but I doubt introducing a new pass for this is reasonable. I may want to try to find any other good place for this. Please also let me know if you have any suggestion.


http://reviews.llvm.org/D16203





More information about the llvm-commits mailing list