[PATCH] D17020: [PGO] Revisied patch: Differentiate Clang instrumentation and IR level instrumentation profiles

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 22:11:59 PST 2016


xur created this revision.
xur added reviewers: davidxl, silvas, bogner.
xur added subscribers: llvm-commits, t.p.northover.

The original review is: Differential Revision: http://reviews.llvm.org/D15540

I reverted the commit r260164 because it broke one darwin test in compile-rt/profile/

The reason for the breakage is Mach-O platform doesn’t support COMDATs. In this revised patch, I create a linkonce variable for the MachO platform and remain to create a comdat variable for other platforms. 

I change the test Transform/PGOInstrumentation/branch1.ll to test linkonce variable creation. 

Other part of the patch is the same.

Tested the patch in Marbook pro and Linux.

Thanks,

-Rong

http://reviews.llvm.org/D17020

Files:
  include/llvm/ProfileData/InstrProfData.inc
  include/llvm/ProfileData/InstrProfReader.h
  include/llvm/ProfileData/InstrProfWriter.h
  lib/ProfileData/InstrProfReader.cpp
  lib/ProfileData/InstrProfWriter.cpp
  lib/Transforms/Instrumentation/PGOInstrumentation.cpp
  test/Transforms/PGOProfile/Inputs/branch1.proftext
  test/Transforms/PGOProfile/Inputs/branch2.proftext
  test/Transforms/PGOProfile/Inputs/criticaledge.proftext
  test/Transforms/PGOProfile/Inputs/diag.proftext
  test/Transforms/PGOProfile/Inputs/diag_FE.proftext
  test/Transforms/PGOProfile/Inputs/landingpad.proftext
  test/Transforms/PGOProfile/Inputs/loop1.proftext
  test/Transforms/PGOProfile/Inputs/loop2.proftext
  test/Transforms/PGOProfile/Inputs/switch.proftext
  test/Transforms/PGOProfile/branch1.ll
  test/Transforms/PGOProfile/branch2.ll
  test/Transforms/PGOProfile/criticaledge.ll
  test/Transforms/PGOProfile/diag_FE_profile.ll
  test/Transforms/PGOProfile/landingpad.ll
  test/Transforms/PGOProfile/loop1.ll
  test/Transforms/PGOProfile/loop2.ll
  test/Transforms/PGOProfile/single_bb.ll
  test/Transforms/PGOProfile/switch.ll
  tools/llvm-profdata/llvm-profdata.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17020.47296.patch
Type: text/x-patch
Size: 22347 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160209/2194186a/attachment.bin>


More information about the llvm-commits mailing list