[PATCH] D17013: Add convergent-removing bits to FunctionAttrs pass.

[Mehdi AMINI via llvm-commits]

joker.eph added inline comments.

================
Comment at: lib/Transforms/IPO/FunctionAttrs.cpp:936
@@ +935,3 @@
+static bool removeConvergentAttrs(const CallGraphSCC &SCC) {
+  const CallGraphNode *CGN = *SCC.begin();
+  Function *F = CGN->getFunction();
----------------
jingyue wrote:
> `SCC` may contain multiple functions. In that case, you need to consider all of them. 
That's a good point: any reason not to take the `SCCNodeSet` and iterate over like `addNonNullAttrs` for instance?


http://reviews.llvm.org/D17013