[PATCH] D17006: Refactor PGO function naming and MD5 hashing support out of ProfileData

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In http://reviews.llvm.org/D17006#347035, @davidxl wrote:

> This one LGTM. I am also expecting another interface like  'getFunctionGuid' to wrap around the MD5Hash method..


Do you mean to basically do MD5Hash(getGlobalIdentifier(...))? I could add that with the follow-on patch to use this in the ThinLTO function map. Although for now in the draft patch I am testing they are invoked in slightly different places (the MD5Hash is hidden within the FunctionInfoIndex methods which take a string, and getGlobalIdentifier is invoked as needed above that. And for PGO, it didn't look like MD5Hash and getPGOFuncName were invoked simultaneously.


http://reviews.llvm.org/D17006