[PATCH] D14128: Enable readobj to emit readelf like output.

[khemant@codeaurora.org via llvm-commits]

khemant marked 3 inline comments as done.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:2296
@@ +2295,3 @@
+  printFields("Entry point address:", Str);
+  Str = std::to_string(e->e_phoff) + " (bytes into file)";
+  printFields("Start of program headers:", Str);
----------------
echristo wrote:
> khemant wrote:
> > Some versions of Cygwin apparently have newlib that do not support std::to_string. There needs to be a change to remove these calls.
> Is this an issue for any targets we have a bot for?
Yes. There are a couple of cygwin bots I believe. I found this when I checked this commit:
520b6856921a0d4b9f079f532b53a56199521cf2


Repository:
  rL LLVM

http://reviews.llvm.org/D14128