[PATCH] D16968: [llvm-readobj][ELF] Show MIPS GOT content when there is another zero-sized section at the same address

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 13:55:37 PST 2016


rafael added inline comments.

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:1889
@@ +1888,3 @@
+  if (!GOTShdr) {
+    W.startLine() << "There is no not empty GOT section at "
+                  << format("0x%" PRIX64, *DtPltGot) << ".\n ";
----------------
This is a corrupted file and should be an error, no?

================
Comment at: tools/llvm-readobj/ELFDumper.cpp:1966
@@ +1965,3 @@
+  const Elf_Shdr *PLTRelShdr = findNotEmptySectionByAddress(Obj, *DtJmpRel);
+  if (!PLTRelShdr) {
+    W.startLine() << "There is no not empty RELPLT section at "
----------------
This is also a corrupted file, no?


Repository:
  rL LLVM

http://reviews.llvm.org/D16968





More information about the llvm-commits mailing list