[PATCH] D16730: [PGO] cc1 option names change for profile instrumentation (NFC)

Rong Xu via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 10:17:43 PST 2016


Thanks Sean. I committed r260116 to fix the bad format for ':'.

-Rong

On Fri, Feb 5, 2016 at 6:38 PM, Sean Silva <chisophugis at gmail.com> wrote:
> silvas accepted this revision.
> silvas added a comment.
> This revision is now accepted and ready to land.
>
> Tiny nit, but this LGTM as well.
>
>
> ================
> Comment at: include/clang/Basic/DiagnosticDriverKinds.td:30
> @@ -29,1 +29,3 @@
>    "invalid linker name in argument '%0'">;
> +def err_drv_invalid_pgo_instrumentor: Error<
> +  "invalid PGO instrumentor in argument '%0'">;
> ----------------
> This `:` is inconsistently placed. (also for some of the other tablegen changes)
>
>
> http://reviews.llvm.org/D16730
>
>
>


More information about the llvm-commits mailing list