[PATCH] D16960: [FIX] Associate access relations with an AccessId

[Tobias Grosser via llvm-commits]

grosser added a comment.

Hi Johannes,

I wonder what changed your mind?

I personally was not yet convinced the patch as proposed was a step in 
the right direction. My main concern was that it introduced multiple, 
distinct isl_ids that all had the same "string" representation, which I 
am afraid might cause confusion on the way.

I am currently happy with creating address-of expressions and then 
introducing the relevant casts ourselves. Another option I could see is 
to introduce in the IslExprBuilder a function that takes an address_of 
expression as well as a MemoryAccess and encapsulates the address 
creation and type casting.

Best,
Tobias


http://reviews.llvm.org/D16960