[PATCH] D16956: [X86][SSE1] Add MOVLHPS/MOVHLPS lowering and memory folding support

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 8 07:06:05 PST 2016


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

Please see another inline comment for hasPartialRegUpdate(). LGTM after that is addressed.


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:5763-5766
@@ -5743,2 +5762,6 @@
   case X86::Int_CVTSS2SDrm:
+  case X86::MOVHPDrm:
+  case X86::MOVHPSrm:
+  case X86::MOVLPDrm:
+  case X86::MOVLPSrm:
   case X86::RCPSSr:
----------------
We're creating MOVLHPSrr / MOVHLPSrr with this patch, so I think those should be included too.


Repository:
  rL LLVM

http://reviews.llvm.org/D16956





More information about the llvm-commits mailing list