[PATCH] D16683: [X86][SSE] Resolve target shuffle inputs to sentinels to permit more combines

[Sanjay Patel via llvm-commits]

spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - see inline comments for a couple of nits.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:23691
@@ +23690,3 @@
+
+  // See if we can recurse into Input0 (if its a target shuffle).
+  if (Input0 && Op->isOnlyUserOf(Input0.getNode()) &&
----------------
it's

================
Comment at: test/CodeGen/X86/pshufb-mask-comments.ll:34
@@ -33,3 +33,3 @@
 ; CHECK-LABEL: test4
-; CHECK: pshufb {{.*}}
+; CHECK-NOT: pshufb {{.*}}
   store <2 x i64> <i64 1084818905618843912, i64 506097522914230528>, <2 x i64>* %V, align 16
----------------
It would be better to check the correct/expected output instead.


Repository:
  rL LLVM

http://reviews.llvm.org/D16683