[PATCH] D16809: [JumpThreading] See through Cast Instructions

Balaram Makam via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 7 05:14:35 PST 2016


bmakam added a comment.

LGTM once you've addressed the comments.


================
Comment at: lib/Transforms/Scalar/JumpThreading.cpp:415
@@ +414,3 @@
+    if (Value *NewV = SimplifyInstruction(I, BB->getModule()->getDataLayout()))
+      V = NewV;
+
----------------
You might need to RAUW NewV, 
NewV->replaceAllUsesWith(V);
V->eraseFromParent();



Repository:
  rL LLVM

http://reviews.llvm.org/D16809





More information about the llvm-commits mailing list