[PATCH] D16850: [sanitizer_common] Add suffix to lit testsuite name to distinguish subtargets.

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 14:32:58 PST 2016


samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

LGTM. Thank you!


================
Comment at: test/sanitizer_common/CMakeLists.txt:39
@@ -38,2 +38,3 @@
     set(CONFIG_NAME ${tool}-${arch}-${OS_NAME})
+    set(SANITIZER_COMMON_TEST_CONFIG_SUFFIX "-${arch}-${OS_NAME}")
     configure_lit_site_cfg(
----------------
probably CONFIG_NAME should be enough...

================
Comment at: test/sanitizer_common/lit.common.cfg:6
@@ -5,3 +5,3 @@
 
-config.name = "SanitizerCommon-" + config.tool_name
+config.name = "SanitizerCommon-" + config.tool_name + config.name_suffix
 
----------------
... and this "SanitizerCommon-" + config.name_suffix?

================
Comment at: test/sanitizer_common/lit.site.cfg.in:5
@@ -4,2 +4,3 @@
 # Tool-specific config options.
+config.name_suffix = "@SANITIZER_COMMON_TEST_CONFIG_SUFFIX@"
 config.tool_name = "@SANITIZER_COMMON_LIT_TEST_MODE@"
----------------
Can you just make it "@CONFIG_NAME@"?


http://reviews.llvm.org/D16850





More information about the llvm-commits mailing list