[PATCH] D16933: [AArch64] Merge two adjacent str WZR into str XZR

[Tim Northover via llvm-commits]

t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.

Hi Jun,

I think this looks fine as code. Just a couple of minor grammatical nits before committing.


================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:636
@@ -631,1 +635,3 @@
 
+static bool isZeroStorePromote(MachineInstr *MI) {
+  MachineOperand MO = getLdStRegOp(MI);
----------------
I think you mean "isPromotableZeroStore" here.

================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1106
@@ -1093,3 +1105,3 @@
   int Offset = getLdStOffsetOp(FirstMI).getImm();
-  bool IsNarrowStore = isNarrowStore(Opc);
+  bool IsZeroStoreMerge = isZeroStorePromote(FirstMI);
 
----------------
Again, "IsMergeableZeroStore" conveys the meaning better.


http://reviews.llvm.org/D16933