[llvm] r259915 - CallAnalyzer::analyzeCall: change the condition back to "Cost < Threshold"

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 12:32:42 PST 2016


Author: hans
Date: Fri Feb  5 14:32:42 2016
New Revision: 259915

URL: http://llvm.org/viewvc/llvm-project?rev=259915&view=rev
Log:
CallAnalyzer::analyzeCall: change the condition back to "Cost < Threshold"

In r252595, I inadvertently changed the condition to "Cost <= Threshold",
which caused a significant size regression in Chrome. This commit rectifies
that.

Modified:
    llvm/trunk/lib/Analysis/InlineCost.cpp

Modified: llvm/trunk/lib/Analysis/InlineCost.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/InlineCost.cpp?rev=259915&r1=259914&r2=259915&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/InlineCost.cpp (original)
+++ llvm/trunk/lib/Analysis/InlineCost.cpp Fri Feb  5 14:32:42 2016
@@ -1392,7 +1392,7 @@ bool CallAnalyzer::analyzeCall(CallSite
   else if (NumVectorInstructions <= NumInstructions / 2)
     Threshold -= (FiftyPercentVectorBonus - TenPercentVectorBonus);
 
-  return Cost <= std::max(0, Threshold);
+  return Cost < std::max(1, Threshold);
 }
 
 #if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)




More information about the llvm-commits mailing list