[llvm] r259812 - [AArch64] Improve load/store optimizer to handle LDUR + LDR (take 3).

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 07:58:49 PST 2016


Thanks, Renato.  Sorry for the breakage.  I'll investigate shortly.

-----Original Message-----
From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: Friday, February 05, 2016 7:26 AM
To: Chad Rosier
Cc: LLVM Commits
Subject: Re: [llvm] r259812 - [AArch64] Improve load/store optimizer to handle LDUR + LDR (take 3).

On 4 February 2016 at 18:59, Chad Rosier via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: mcrosier
> Date: Thu Feb  4 12:59:49 2016
> New Revision: 259812
>
> URL: http://llvm.org/viewvc/llvm-project?rev=259812&view=rev
> Log:
> [AArch64] Improve load/store optimizer to handle LDUR + LDR (take 3).
>
> This patch allows the mixing of scaled and unscaled load/stores to form
> load/store pairs.
>
> PR24465
> http://reviews.llvm.org/D12116
> Many thanks to Ahmed and Michael for fixes and code review.
>
> This is a reapplication of r246769 and r259790.  The tramp3d failure was caused
> by an incorrect refactoring in the patch.  Specifically, we weren't always
> properly clearing the SExtIdx flag.

Hi Chad,

This broke the self-hosting build:

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/1341

I have reverted it for now.

Attached is the cpp/zip file that broke. Note that this is while
self-hosting, so you'll have to use a clang compiled with your patch
in order to reproduce.

We are pushing the installation directories to the bisect Google
drive, so you can get one of them in the window which your patch was
applied.

cheers,
--renato



More information about the llvm-commits mailing list