[PATCH] D15642: [asan] Use private aliases for global variables (LLVM part).

Maxim Ostapenko via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 5 03:30:43 PST 2016


m.ostapenko updated the summary for this revision.
m.ostapenko updated this revision to Diff 47006.
m.ostapenko added a comment.

Updating according to Alexey's review.

I've also realized, that we should not copy all attributes from NewGlobal (e.g. we don't need it's alignment and section name) to ODR indicator symbol (thanks Yura for pointing to this!), we just need some of them (Visibility, DLLStorageClass and ThreadLocalMode). Full list of attributes available for copying is here:

  LinkageType               (set in constructor)
  VisibilityType
  DLLStorageClassType
  Section
  Alignment
  ThreadLocalMode      (set in constructor)
  isExternallyInitialized  (set in constructor)

Does this look better now?


Repository:
  rL LLVM

http://reviews.llvm.org/D15642

Files:
  lib/Transforms/Instrumentation/AddressSanitizer.cpp
  test/Instrumentation/AddressSanitizer/local_alias.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15642.47006.patch
Type: text/x-patch
Size: 7068 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160205/f9db45c0/attachment.bin>


More information about the llvm-commits mailing list