[PATCH] D16388: [PGO] Enable profile name compression
Vedant Kumar via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 4 16:46:50 PST 2016
vsk added a comment.
Lgtm.
================
Comment at: lib/Transforms/Instrumentation/InstrProfiling.cpp:296
@@ -283,3 +295,3 @@
StringRef ComdatPrefix = (Triple(M.getTargetTriple()).isOSBinFormatCOFF()
- ? getInstrProfNameVarPrefix()
+ ? getInstrProfCountersVarPrefix()
: getInstrProfComdatPrefix());
----------------
davidxl wrote:
> vsk wrote:
> > This change seems inconsistent with the comment above it -- why start using the counter var prefix for COFF comdats?
> Will fix the comment. The name var comdat no long exists.
D'oh. Right.
http://reviews.llvm.org/D16388
More information about the llvm-commits
mailing list