[PATCH] D10725: Improve testing for the C API

[Eric Christopher via llvm-commits]

echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

This is looking pretty good. Definitely for a first start. Thanks for doing this and sticking with it.

-eric


================
Comment at: tools/llvm-c-test/echo.cpp:271
@@ +270,3 @@
+        fprintf(stderr, "Final instruction does not match Last\n");
+        exit(-1);
+      }
----------------
Sure.

================
Comment at: tools/llvm-c-test/echo.cpp:284
@@ +283,3 @@
+    Cur = Next;
+  }
+
----------------
Nothing is coming to mind at the moment, we can just defer it.

================
Comment at: tools/llvm-c-test/echo.cpp:335-338
@@ +334,6 @@
+
+  ValueMap VMap;
+  if (Count == 0)
+    return VMap;
+
+  LLVMValueRef SrcFirst = LLVMGetFirstParam(Src);
----------------
I think I was just wanting a testcase with more than zero parameters when I asked.


http://reviews.llvm.org/D10725