[PATCH] D16809: [JumpThreading] See through Cast Instructions

Geoff Berry via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 12:10:20 PST 2016


gberry added a comment.

It is not clear to me from looking at the added test case what new optimization is being added.  I would expect to see some CHECKs of new folded constants if I understand the change correctly.


================
Comment at: test/Transforms/JumpThreading/basic.ll:495
@@ +494,3 @@
+	%B = phi i32 [1, %Entry], [%v1, %F1]
+        %M = icmp eq i32 %B, 0 
+        %M1 = zext i1 %M to i32
----------------
These 3 lines are indented funny (tabs?)


Repository:
  rL LLVM

http://reviews.llvm.org/D16809





More information about the llvm-commits mailing list