[PATCH] D16887: Avoid code duplication when creating dynamic relocations

[George Rimar via llvm-commits]

grimar added a subscriber: grimar.

================
Comment at: ELF/OutputSections.cpp:249
@@ +248,3 @@
+        return Rel.Sym->template getGotPltVA<ELFT>();
+      }
+    };
----------------
Don't you need some kind of "unknown reloc type" assert here ?

================
Comment at: ELF/OutputSections.h:188
@@ +187,3 @@
+  } OKind;
+
+  SymbolBody *Sym = nullptr;
----------------
Not all comments have a dot at the end.

================
Comment at: ELF/Writer.cpp:946
@@ -907,1 +945,3 @@
+  addRelIpltSymbols();
+
   // Scan relocations. This must be done after every symbol is declared so that
----------------
Was that intentionaly moved ?


Repository:
  rL LLVM

http://reviews.llvm.org/D16887