[llvm] r259799 - The canonical way to XFAIL a test for all targets is XFAIL: *, not XFAIL:

Benjamin Kramer via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 4 08:21:38 PST 2016


Author: d0k
Date: Thu Feb  4 10:21:38 2016
New Revision: 259799

URL: http://llvm.org/viewvc/llvm-project?rev=259799&view=rev
Log:
The canonical way to XFAIL a test for all targets is XFAIL: *, not XFAIL:

Fix the lit bug that enabled this "feature" (empty triple is substring
of all possible target triples) and change the two outliers to use the
documented * syntax.

Modified:
    llvm/trunk/test/CodeGen/Hexagon/struct_args_large.ll
    llvm/trunk/test/Transforms/Util/MemorySSA/load-invariant.ll
    llvm/trunk/utils/lit/lit/Test.py

Modified: llvm/trunk/test/CodeGen/Hexagon/struct_args_large.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/Hexagon/struct_args_large.ll?rev=259799&r1=259798&r2=259799&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/Hexagon/struct_args_large.ll (original)
+++ llvm/trunk/test/CodeGen/Hexagon/struct_args_large.ll Thu Feb  4 10:21:38 2016
@@ -1,4 +1,4 @@
-; XFAIL:
+; XFAIL: *
 ; RUN: llc -march=hexagon < %s | FileCheck %s
 ; CHECK: r[[T0:[0-9]+]] = CONST32(#s2)
 ; CHECK: memw(r29+#0) = r{{.}}

Modified: llvm/trunk/test/Transforms/Util/MemorySSA/load-invariant.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/Util/MemorySSA/load-invariant.ll?rev=259799&r1=259798&r2=259799&view=diff
==============================================================================
--- llvm/trunk/test/Transforms/Util/MemorySSA/load-invariant.ll (original)
+++ llvm/trunk/test/Transforms/Util/MemorySSA/load-invariant.ll Thu Feb  4 10:21:38 2016
@@ -1,4 +1,4 @@
-; XFAIL:
+; XFAIL: *
 ; RUN: opt -basicaa -print-memoryssa -verify-memoryssa -analyze < %s 2>&1 | FileCheck %s
 ;
 ; Invariant loads should be considered live on entry, because, once the

Modified: llvm/trunk/utils/lit/lit/Test.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/Test.py?rev=259799&r1=259798&r2=259799&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/Test.py (original)
+++ llvm/trunk/utils/lit/lit/Test.py Thu Feb  4 10:21:38 2016
@@ -230,7 +230,7 @@ class Test:
                 return True
 
             # If this is a part of the target triple, it fails.
-            if item in self.suite.config.target_triple:
+            if item and item in self.suite.config.target_triple:
                 return True
 
         return False




More information about the llvm-commits mailing list